How to loop through multiple entries fields

Question

I'm creating a dynamic side navigation where pages can choose which sidebar it wants to use. This is selected by an entries field called 'sidebar' - called in line 2.

To create this I've made a structure called 'Sidebars' with an entry for each sidebar type. Each Sidebars entry has an entries field in it which can select any number of pages.

I've got it fully working, but it's giving me deprecation errors.

Here's the working (but deprecated code on line 4): (lines 5-12 figure out whether the path includes 'whats-on' or 'who-we-are' and adds them to the path to the entry if needed).

<div>
  {% set sidebarChoice = entry.sidebar.one() %}
  {% for rel in sidebarChoice %}
    {% for sidebarEntry in rel %}
      {% set myEntryQueryUrl = sidebarEntry.url %}
      {% if 'whats-on' in myEntryQueryUrl %}
        {% set myEntryQueryPath = '/whats-on/' %}
      {% elseif 'who-we-are' in myEntryQueryUrl %}
        {% set myEntryQueryPath = '/who-we-are/' %}
      {% else %}
        {% set myEntryQueryPath = '/' %}
      {% endif %}

      <div>
        <h3>{{ sidebarEntry.title }}</h3>
        <a href="{{ myEntryQueryPath }}{{ sidebarEntry.slug}}">
        <p class="smallcontentblocks-text">{{ sidebarEntry.title }} text</p>
        </a>
      </div>

    {% endfor %}
  {% endfor %}
</div>

Answer 1

You don't mention what your related entries field handle is, but remember that calling any related element (entries/assets/categories/users/tags) will require a .all() (or .one() or .ids() or one of the other query-executing methods) unless the related elements are eager-loaded. With that in mind I can't see anywhere in your code where you're executing a call to fetch the related entries from sidebarChoice, and you also seem to have a redundant inner loop. With eager-loading it might look like this:

<div>
  {% set sidebarChoice = entry.sidebar.with(['sidebar.yourRelatedEntriesHandle']).one() %}
  {% for sidebarEntry in sidebarChoice.yourRelatedEntriesHandle %}
      {% set myEntryQueryUrl = sidebarEntry.url %}
      {% if 'whats-on' in myEntryQueryUrl %}
        {% set myEntryQueryPath = '/whats-on/' %}
      {% elseif 'who-we-are' in myEntryQueryUrl %}
        {% set myEntryQueryPath = '/who-we-are/' %}
      {% else %}
        {% set myEntryQueryPath = '/' %}
      {% endif %}

      <div>
        <h3>{{ sidebarEntry.title }}</h3>
        <a href="{{ myEntryQueryPath }}{{ sidebarEntry.slug}}">
          <p class="smallcontentblocks-text">{{ sidebarEntry.title }} text</p>
        </a>
      </div>
  {% endfor %}
</div>

Answer 2

Thanks, the related entries field handle is sidebarTitle.

The first part of the above cleared the errors with an additional .all():

<div>
{% set sidebarChoice = entry.sidebar.with(['sidebar.sidebarTitle']).one() %}
     {% for sidebarEntry in sidebarChoice.sidebarTitle.all() %}
     {% set myEntryQueryUrl = sidebarEntry.url %}
     {% if 'whats-on' in myEntryQueryUrl %}
     {% set myEntryQueryPath = '/whats-on/' %}
     {% elseif 'who-we-are' in myEntryQueryUrl %}
     {% set myEntryQueryPath = '/who-we-are/' %}
     {% else %}
     {% set myEntryQueryPath = '/' %}
     {% endif %}

 <div>
    <h3>{{ sidebarEntry.title }}</h3>
    <a href="{{ myEntryQueryPath }}{{ sidebarEntry.slug}}">
      <p class="smallcontentblocks-text">{{ sidebarEntry.title }} text</p>
    </a>
  </div>
{% endfor %}